-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Generated By Dashwave AI] Implement queue for accessibility announcements in OfflineNoticeProvider #34
base: main
Are you sure you want to change the base?
Conversation
|
|
@dashwave /feedback please add comments to the changes you have made to explain them in detail |
https://github.com/dashwave /feedback please add comments to the changes you have made to explain them in detail |
@dashwave /feedback please add comments to the changes you have made to explain them in detail |
3 similar comments
@dashwave /feedback please add comments to the changes you have made to explain them in detail |
@dashwave /feedback please add comments to the changes you have made to explain them in detail |
@dashwave /feedback please add comments to the changes you have made to explain them in detail |
…ng React Native v0.68 feature
The code changes involve updating the accessibility announcements in the |
|
@dashwave /feedback build failing with the following logs. the logs are provided in the reverse order: [!]BUILD FAILED in 17s |
The build failure is due to the
Please try one of these solutions and let me know if you need further assistance. |
|
This PR addresses the enhancement of accessibility announcements in the OfflineNoticeProvider component by utilizing the new feature available in React Native v0.68. Specifically, it implements the
announceForAccessibilityWithOptions
method to queue announcements behind any in-progress announcements, providing a smoother user experience for iOS users. This change is a follow-up to the previous upgrade task outlined in issue #5344 and PR #5610. By setting the queue option to true, we ensure that announcements such as 'Zulip’s Internet connection is uncertain' and 'Zulip is online' do not interrupt existing speech, enhancing the overall accessibility of the application.