Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Generated By Dashwave AI] Implement queue for accessibility announcements in OfflineNoticeProvider #34

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dashwave[bot]
Copy link

@dashwave dashwave bot commented Nov 19, 2024

This PR addresses the enhancement of accessibility announcements in the OfflineNoticeProvider component by utilizing the new feature available in React Native v0.68. Specifically, it implements the announceForAccessibilityWithOptions method to queue announcements behind any in-progress announcements, providing a smoother user experience for iOS users. This change is a follow-up to the previous upgrade task outlined in issue #5344 and PR #5610. By setting the queue option to true, we ensure that announcements such as 'Zulip’s Internet connection is uncertain' and 'Zulip is online' do not interrupt existing speech, enhancing the overall accessibility of the application.

Copy link
Author

dashwave bot commented Nov 19, 2024

Build Status ❌ Failed
Build Time -
📱 Emulation Link -
Logs See Logs
Open in Workspace Dashwave Workspace

Copy link
Author

dashwave bot commented Nov 19, 2024

Build Status ❌ Failed
Build Time -
📱 Emulation Link -
Logs See Logs
Open in Workspace Dashwave Workspace

@burnerlee
Copy link
Owner

@dashwave /feedback please add comments to the changes you have made to explain them in detail

@burnerlee
Copy link
Owner

https://github.com/dashwave /feedback please add comments to the changes you have made to explain them in detail

@burnerlee
Copy link
Owner

@dashwave /feedback please add comments to the changes you have made to explain them in detail

3 similar comments
@burnerlee
Copy link
Owner

@dashwave /feedback please add comments to the changes you have made to explain them in detail

@burnerlee
Copy link
Owner

@dashwave /feedback please add comments to the changes you have made to explain them in detail

@burnerlee
Copy link
Owner

@dashwave /feedback please add comments to the changes you have made to explain them in detail

Copy link
Author

dashwave bot commented Nov 19, 2024

The code changes involve updating the accessibility announcements in the OfflineNoticeProvider component to use the announceForAccessibilityWithOptions method, which allows queuing announcements behind any in-progress announcements. This is done by replacing the announceForAccessibility method with announceForAccessibilityWithOptions and setting the queue option to true. This change ensures that accessibility announcements are queued rather than interrupting ongoing announcements, providing a smoother experience for users relying on screen readers. Comments have been added to explain these changes in detail.

Copy link
Author

dashwave bot commented Nov 19, 2024

Build Status ❌ Failed
Build Time -
📱 Emulation Link -
Logs See Logs
Open in Workspace Dashwave Workspace

@burnerlee
Copy link
Owner

@dashwave /feedback build failing with the following logs. the logs are provided in the reverse order:

[!]BUILD FAILED in 17s
[!]
[!]* Get more help at https://help.gradle.org
[!]
[!]==============================================================================
[!]> Run with --scan to get full insights.
[!]> Run with --info or --debug option to get more log output.
[+]496 actionable tasks: 8 executed, 488 up-to-date
[+]Please consult deprecation warnings for more details.
[+]Execution optimizations have been disabled for 1 invalid unit(s) of work during this build to ensure correctness.
[+]
[+]See https://docs.gradle.org/7.3.3/userguide/command_line_interface.html#sec:command_line_warnings
[+]
[+]You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
[+]
[!]> Run with --stacktrace option to get the stack trace.
[!]* Try:
[!]
[!] project :react-native-photo-view
[!] Required by:
[!] > Could not find me.relex:photodraweeview:1.1.3.
[!]> Could not resolve all files for configuration ':react-native-photo-view:debugCompileClasspath'.
[!]Execution failed for task ':react-native-photo-view:generateDebugRFile'.
[!]* What went wrong:
[!]-----------
[!]2: Task failed with an exception.
[!]
[+]Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.
[+]
[!]==============================================================================
[!]> Run with --scan to get full insights.
[!]> Run with --info or --debug option to get more log output.
[!]> Run with --stacktrace option to get the stack trace.
[!]* Try:
[!]
[!] project :app > project :react-native-photo-view
[!] Required by:
[!] - https://jcenter.bintray.com/me/relex/photodraweeview/1.1.3/photodraweeview-1.1.3.pom
[!] - https://dl.google.com/dl/android/maven2/me/relex/photodraweeview/1.1.3/photodraweeview-1.1.3.pom
[!] - https://repo.maven.apache.org/maven2/me/relex/photodraweeview/1.1.3/photodraweeview-1.1.3.pom
[!] - file:/workspace/code/node_modules/jsc-android/dist/me/relex/photodraweeview/1.1.3/photodraweeview-1.1.3.pom
[!] Searched in the following locations:
[!] > Could not find me.relex:photodraweeview:1.1.3.
[!]> Could not resolve all files for configuration ':app:debugRuntimeClasspath'.
[!]Execution failed for task ':app:checkDebugAarMetadata'.
[!]* What went wrong:
[!]-----------
[!]1: Task failed with an exception.
[!]
[!]FAILURE: Build completed with 2 failures.

Copy link
Author

dashwave bot commented Nov 19, 2024

The build failure is due to the react-native-photo-view dependency, which is trying to resolve me.relex:photodraweeview:1.1.3 from repositories that no longer host it. To fix this, you can try the following steps:

  1. Update Dependency: Check if there's a newer version of react-native-photo-view that resolves this issue or consider using an alternative library that provides similar functionality.

  2. Add Repository: If the library is still available but hosted elsewhere, you can add the repository URL to your build.gradle file under repositories.

  3. Local Dependency: As a temporary workaround, you can download the required library manually and include it as a local dependency in your project.

  4. Use JitPack: If the library is hosted on a public GitHub repository, you can use JitPack to resolve it by adding JitPack to your repositories in build.gradle.

Please try one of these solutions and let me know if you need further assistance.

Copy link
Author

dashwave bot commented Nov 19, 2024

Build Status ❌ Failed
Build Time -
📱 Emulation Link -
Logs See Logs
Open in Workspace Dashwave Workspace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant