Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Generated By Dashwave AI] Fix status bar color mismatch in landscape mode #38

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Generated By Dashwave AI] Fix status bar color mismatch in landscape mode #38

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db75d66
Fix status bar color issue in landscape mode
Nov 20, 2024
68243ac
Ensure ZulipStatusBar renders consistently across orientations
Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/common/ZulipStatusBar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,19 +50,19 @@
const osScheme = useColorScheme();
const themeToUse = getThemeToUse(theme, osScheme);

// Get the current orientation from the global session state
const orientation = useGlobalSelector(state => getGlobalSession(state).orientation);

Check warning on line 54 in src/common/ZulipStatusBar.js

View workflow job for this annotation

GitHub Actions / test 

'orientation' is assigned a value but never used

Check warning on line 54 in src/common/ZulipStatusBar.js

View workflow job for this annotation

GitHub Actions / test 

'orientation' is assigned a value but never used
const backgroundColor = props.backgroundColor;
const statusBarColor = getStatusBarColor(backgroundColor, themeToUse);

// Render the StatusBar component with the appropriate props
return (
orientation === 'PORTRAIT' && (
<StatusBar
animated
showHideTransition="slide"
hidden={hidden && Platform.OS !== 'android'}
backgroundColor={Color(statusBarColor).darken(0.1).hsl().string()}
barStyle={getStatusBarStyle(statusBarColor)}
/>
)
<StatusBar
animated
showHideTransition="slide"
hidden={hidden && Platform.OS !== 'android'}
backgroundColor={Color(statusBarColor).darken(0.1).hsl().string()}
barStyle={getStatusBarStyle(statusBarColor)}
/>
);
}
Loading