-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(helm): ServiceMonitor namespace override #563
fix(helm): ServiceMonitor namespace override #563
Conversation
Hey @dtjm, thanks for your contribution! 👍 Could you please also execute the following command as per our recommendation (as it contains additional templating):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to run make gen_docs
to render docs automatically and submit the changes to the PR.
Thank you @burningalchemist , sorry I failed to actually read the instructions =) I've pushed that new rendering in eb65d16. |
@dtjm No worries, thanks for adding the changes. 👍 |
👍🏽 thank you for making this code open source! |
v0.6.1 should be available shortly! 🚀 |
if I set
serviceMonitor.namespace
, it overrides the namespace where the ServiceMonitor is deployed. However, the pod is deployed in the same namespace, so I'd like this to override the namespace inmatchNamespace
spec field also.