Draft implementation: new subcommand for computing obfuscation map #850
+325
−163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a draft implementation for the proposal described at #849.
The
transformer.transformGoFile
method contains some code that computes the obfuscated identifier for a giventypes.Object
.This patch does essentially two things:
transformer.transformGoFile
method, lifting the code segment mentioned above into an independently callable method namedtransformer.obfuscateObjectName
;garble map
that uses the newly added methodtransformer.obfuscateObjectName
to compute the output described at Feature proposal: new subcommand for computing obfuscation map #849.The refactoring step is necessary to ensure the
garble map
command stays in sync with the algorithm used bytransformGoFile
.I have not added a test yet because I am not familiar with the scripting language and it is also not entirely clear to me what the best approach would be for testing the new command.
The implementation of the new command resembles vaguely that of the
reverse
subcommand:types.Object
;transformer.obfuscatedObjectName
on the current object;golang.org/x/tools/go/types/objectpath
to compute a path for the current object;