Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action typing #58

Closed
Vampire opened this issue Jan 23, 2023 · 2 comments · Fixed by #59
Closed

Add action typing #58

Vampire opened this issue Jan 23, 2023 · 2 comments · Fixed by #59

Comments

@Vampire
Copy link
Contributor

Vampire commented Jan 23, 2023

I'm looking to get your action first-class supported by https://github.com/krzema12/github-workflows-kt, a Kotlin DSL to write GitHub Action workflows.

They came up with a way to reduce operational load when keeping library's action wrappers in sync with actions' inputs and outputs. The solution includes onboarding https://github.com/krzema12/github-actions-typing. It's as easy as adding an extra YAML file to your repository root, and adding a simple GitHub workflow that validates this new file. Thanks to this, the code generator in the Kotlin DSL can fetch typing info provided by you instead of them, which has a number of benefits. It has no negative effects on current action consumers, they continue to use the action via regular GitHub API, as if the file wasn't there.

In this feature request, I would like to ask you if you're open to introducing such typings in your actions. You wouldn't be first - there's already other actions using it, like e.g. mine: https://github.com/Vampire/setup-wsl

If your answer is "yes", feel free to either add it yourself, or let me know - me or some of the library contributors / maintainers would be happy to post PRs. They're also open to any kind of questions and feedback.

@vlsi
Copy link
Contributor

vlsi commented Jan 23, 2023

It would be great if you could help with the typings

Vampire added a commit to Vampire/gradle-cache-action that referenced this issue Jan 23, 2023
@Vampire
Copy link
Contributor Author

Vampire commented Jan 23, 2023

There you have it :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants