-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing instance of AwsCredentialsProvider to configuration #25
Allow passing instance of AwsCredentialsProvider to configuration #25
Conversation
This enables being more explicit about the provider chain to use in cases where the lookupDefaultAwsCredentials is not viable, or where you have a custom subclass of AwsCredentialsProvider you need to use
I am afraid passing non-trivial objects to the Could you please add a test (e.g. to gradle-s3-build-cache/src/test/kotlin/com/github/burrunan/s3cache/RemoteCacheTest.kt Lines 127 to 135 in 4d26ab7
|
Added a very basic example to the test fixture. I think maybe just making the S3Client creation lazy in that previous commit was all that is really needed to be configuration cache compatible. I tested some of my own builds with this and gradle reported no issues with it. |
Great, thank you |
Will release it shortly |
We've been using this with a custom |
Wow. I thought I released this. Let me check it again. |
I've published 1.7 to Central and GPP. Sorry for the delay, and thanks for the reminder. |
This enables being more explicit about the provider chain to use in cases where the
lookupDefaultAwsCredentials
is not viable, or where you have a custom subclass ofAwsCredentialsProvider
you need to use.