feat: add x-terminal:clear command (#216)

bus-stop · Nov 27, 2020 · 228e621 · 228e621
1 parent d7c995e
commit 228e621
Show file tree

Hide file tree

Showing 17 changed files with 1,028 additions and 918 deletions.
diff --git a/keymaps/x-terminal.json b/keymaps/x-terminal.json
@@ -49,14 +49,16 @@
  "ctrl-shift-c": "x-terminal:copy",
  "shift-insert": "x-terminal:paste",
  "ctrl-shift-v": "x-terminal:paste",
- "ctrl-shift-u": "x-terminal:unfocus"
+ "ctrl-shift-u": "x-terminal:unfocus",
+ "ctrl-l": "x-terminal:clear"
  },
  ".platform-win32 x-terminal": {
  "ctrl-insert": "x-terminal:copy",
  "ctrl-shift-c": "x-terminal:copy",
  "shift-insert": "x-terminal:paste",
  "ctrl-shift-v": "x-terminal:paste",
- "ctrl-shift-u": "x-terminal:unfocus"
+ "ctrl-shift-u": "x-terminal:unfocus",
+ "ctrl-l": "x-terminal:clear"
  },
  ".platform-darwin x-terminal": {
  "ctrl-shift-c": "x-terminal:copy",
@@ -65,6 +67,7 @@
  "shift-insert": "x-terminal:paste",
  "cmd-c": "x-terminal:copy",
  "cmd-v": "x-terminal:paste",
- "ctrl-shift-u": "x-terminal:unfocus"
+ "ctrl-shift-u": "x-terminal:unfocus",
+ "ctrl-l": "x-terminal:clear"
  }
 }
diff --git a/menus/x-terminal.json b/menus/x-terminal.json
@@ -17,6 +17,10 @@
  "label": "Restart",
  "command": "x-terminal:restart"
  },
+ {
+ "label": "Clear",
+ "command": "x-terminal:clear"
+ },
  {
  "type": "separator"
  },

diff --git a/spec/delete-profile-element-spec.js b/spec/delete-profile-element-spec.js
@@ -22,21 +22,21 @@
 import { XTerminalDeleteProfileElement } from '../src/delete-profile-element'
 
 describe('XTerminalDeleteProfileElement', () => {
- this.model = null
+ let model
 
  beforeEach(() => {
- this.model = jasmine.createSpyObj('model', ['setElement'])
+ model = jasmine.createSpyObj('model', ['setElement'])
  })
 
  it('initialize()', () => {
  const element = new XTerminalDeleteProfileElement()
- element.initialize(this.model)
+ element.initialize(model)
  expect(element.promptButtonsDiv.childElementCount).toBe(0)
  })
 
  it('setNewPrompt()', () => {
  const element = new XTerminalDeleteProfileElement()
- element.initialize(this.model)
+ element.initialize(model)
  const profileName = 'foo'
  const confirmHandler = () => {}
  const cancelHandler = () => {}

diff --git a/spec/delete-profile-model-spec.js b/spec/delete-profile-model-spec.js
@@ -22,54 +22,54 @@
 import { XTerminalDeleteProfileModel } from '../src/delete-profile-model'
 
 describe('XTerminalDeleteProfileModel', () => {
- this.atomXtermProfileMenuElement = null
+ let atomXtermProfileMenuElement
 
  beforeEach(() => {
- this.atomXtermProfileMenuElement = jasmine.createSpy(
+ atomXtermProfileMenuElement = jasmine.createSpy(
  'atomXtermProfileMenuElement',
  )
  })
 
  it('constructor()', () => {
- const model = new XTerminalDeleteProfileModel(this.atomXtermProfileMenuElement)
+ const model = new XTerminalDeleteProfileModel(atomXtermProfileMenuElement)
  expect(model).not.toBeNull()
  })
 
  it('getTitle()', () => {
- const model = new XTerminalDeleteProfileModel(this.atomXtermProfileMenuElement)
+ const model = new XTerminalDeleteProfileModel(atomXtermProfileMenuElement)
  expect(model.getTitle()).toBe('X Terminal Delete Profile Model')
  })
 
  it('getElement()', () => {
- const model = new XTerminalDeleteProfileModel(this.atomXtermProfileMenuElement)
+ const model = new XTerminalDeleteProfileModel(atomXtermProfileMenuElement)
  expect(model.getElement()).toBeNull()
  })
 
  it('setElement()', () => {
- const model = new XTerminalDeleteProfileModel(this.atomXtermProfileMenuElement)
+ const model = new XTerminalDeleteProfileModel(atomXtermProfileMenuElement)
  const element = jasmine.createSpy('atomXtermDeleteProfileElement')
  model.setElement(element)
  expect(model.getElement()).toBe(element)
  })
 
  it('close() panel is not visible', () => {
- const model = new XTerminalDeleteProfileModel(this.atomXtermProfileMenuElement)
+ const model = new XTerminalDeleteProfileModel(atomXtermProfileMenuElement)
  model.panel = jasmine.createSpyObj('panel', ['isVisible', 'hide'])
  model.panel.isVisible.and.returnValue(false)
  model.close()
  expect(model.panel.hide).not.toHaveBeenCalled()
  })
 
  it('close() panel is visible', () => {
- const model = new XTerminalDeleteProfileModel(this.atomXtermProfileMenuElement)
+ const model = new XTerminalDeleteProfileModel(atomXtermProfileMenuElement)
  model.panel = jasmine.createSpyObj('panel', ['isVisible', 'hide'])
  model.panel.isVisible.and.returnValue(true)
  model.close()
  expect(model.panel.hide).toHaveBeenCalled()
  })
 
  it('promptDelete() panel is shown', () => {
- const model = new XTerminalDeleteProfileModel(this.atomXtermProfileMenuElement)
+ const model = new XTerminalDeleteProfileModel(atomXtermProfileMenuElement)
  model.panel = jasmine.createSpyObj('panel', ['show', 'isVisible', 'hide'])
  model.panel.isVisible.and.returnValue(true)
  model.element = jasmine.createSpyObj('atomXtermDeleteProfileElement', ['setNewPrompt'])
@@ -78,7 +78,7 @@ describe('XTerminalDeleteProfileModel', () => {
  })
 
  it('promptDelete() new prompt is set', () => {
- const model = new XTerminalDeleteProfileModel(this.atomXtermProfileMenuElement)
+ const model = new XTerminalDeleteProfileModel(atomXtermProfileMenuElement)
  model.panel = jasmine.createSpyObj('panel', ['show', 'isVisible', 'hide'])
  model.panel.isVisible.and.returnValue(true)
  model.element = jasmine.createSpyObj('atomXtermDeleteProfileElement', ['setNewPrompt'])