feat: default command to powershell if available (#177)

BREAKING CHANGE:

Powershell will become the default on windows if the Command setting has not changed from the default. To change it back just delete the Command setting.

package.json

@@ -54,6 +54,7 @@
  "node-pty-prebuilt-multiarch": "^0.9.0",
  "uuid": "^8.3.1",
  "whatwg-url": "^8.3.0",
+ "which": "^2.0.2",
  "xterm": "4.9.0",
  "xterm-addon-fit": "0.4.0",
  "xterm-addon-ligatures": "^0.3.0",

spec/config-spec.js

@@ -19,7 +19,7 @@
  * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { configDefaults, resetConfigDefaults } from '../src/config'
+import { configDefaults, resetConfigDefaults, setInitialCommand } from '../src/config'
 
 import os from 'os'
 import path from 'path'
@@ -448,4 +448,54 @@ describe('config', () => {
  expect(configDefaults.apiOpenPosition).toBe('Center')
  })
  })
+
+ describe('setInitialCommand()', () => {
+ const savedPlatform = process.platform
+
+ beforeEach(() => {
+ Object.defineProperty(process, 'platform', {
+ value: 'win32',
+ })
+ atom.config.set('x-terminal.command', configDefaults.command)
+ })
+
+ afterEach(() => {
+ Object.defineProperty(process, 'platform', {
+ value: savedPlatform,
+ })
+ })
+
+ it('should set x-terminal.command to pwsh', async () => {
+ const shell = 'path/to/pwsh.exe'
+ await setInitialCommand(async (file) => {
+ if (file === 'pwsh.exe') {
+ return shell
+ }
+ throw new Error('ENOENT')
+ })
+
+ expect(atom.config.get('x-terminal.command')).toBe(shell)
+ })
+
+ it('should set x-terminal.command to powershell', async () => {
+ const shell = 'path/to/powershell.exe'
+ await setInitialCommand(async (file) => {
+ if (file === 'powershell.exe') {
+ return shell
+ }
+ throw new Error('ENOENT')
+ })
+
+ expect(atom.config.get('x-terminal.command')).toBe(shell)
+ })
+
+ it('should set x-terminal.command to powershell', async () => {
+ const shell = configDefaults.command
+ await setInitialCommand(async () => {
+ throw new Error('ENOENT')
+ })
+
+ expect(atom.config.get('x-terminal.command')).toBe(shell)
+ })
+ })
 })

src/config.js

@@ -21,6 +21,7 @@
 
 import os from 'os'
 import path from 'path'
+import which from 'which'
 
 export function resetConfigDefaults () {
  return {
@@ -950,3 +951,28 @@ function configToData (obj, prefix) {
 }
 
 export const CONFIG_DATA = configToData(config, 'x-terminal')
+
+export async function setInitialCommand (which) {
+ let command
+ if (process.platform === 'win32') {
+ try {
+ command = await which('pwsh.exe')
+ } catch (e1) {
+ try {
+ command = await which('powershell.exe')
+ } catch (e2) {
+ // powershell not found
+ }
+ }
+ }
+
+ if (command && atom.config.get('x-terminal.command') === configDefaults.command) {
+ atom.config.set('x-terminal.command', command)
+ }
+}
+
+// set shell command automatically on first install
+if (localStorage.getItem('x-terminal.initialCommandSet') === null) {
+ localStorage.setItem('x-terminal.initialCommandSet', 'true')
+ setInitialCommand(which)
+}