Updated dependencies (#455)

* chore: Updated dependencies * chore: Updated ember-source to v5.12.0 * chore: Updated eslint configuration * chore: Updated ember-try configuration * chore: Removed ember-cli-typescript from test-app. Used native types from ember-source in the addon * chore: Added lockfile --------- Co-authored-by: ijlee2 <ijlee2@users.noreply.github.com>
buschtoens · Nov 11, 2024 · 2ce450b · 2ce450b
1 parent fc2f371
commit 2ce450b
Show file tree

Hide file tree

Showing 14 changed files with 2,682 additions and 3,432 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -81,11 +81,10 @@ jobs:
       matrix:
         scenario:
           - 'ember-lts-3.28'
-          - 'ember-lts-4.4'
-          - 'ember-lts-4.8'
           - 'ember-lts-4.12'
-          - 'ember-lts-5.4'
+          - 'ember-lts-5.12'
           - 'ember-release'
+          - 'ember-beta'
           - 'embroider-safe'
           - 'embroider-optimized'
     timeout-minutes: 7

diff --git a/package.json b/package.json
@@ -18,9 +18,9 @@
     "test": "pnpm --filter '*' test"
   },
   "devDependencies": {
-    "@changesets/cli": "^2.27.1",
+    "@changesets/cli": "^2.27.9",
     "@changesets/get-github-info": "^0.6.0",
-    "concurrently": "^8.2.2"
+    "concurrently": "^9.1.0"
   },
   "packageManager": "pnpm@9.12.3",
   "engines": {

diff --git a/packages/ember-codemod-ember-render-helpers-to-v1/package.json b/packages/ember-codemod-ember-render-helpers-to-v1/package.json
@@ -30,31 +30,31 @@
     "test": "./build.sh --test && mt dist-for-testing --quiet"
   },
   "dependencies": {
-    "@codemod-utils/ast-template": "^1.1.2",
-    "@codemod-utils/files": "^2.0.1",
+    "@codemod-utils/ast-template": "^1.1.4",
+    "@codemod-utils/files": "^2.0.4",
     "yargs": "^17.7.2"
   },
   "devDependencies": {
-    "@babel/core": "^7.24.5",
-    "@codemod-utils/tests": "^1.1.4",
+    "@babel/core": "^7.26.0",
+    "@codemod-utils/tests": "^1.1.7",
     "@sondr3/minitest": "^0.1.2",
     "@tsconfig/node18": "^18.2.4",
     "@tsconfig/strictest": "^2.0.5",
-    "@types/node": "^18.19.31",
-    "@types/yargs": "^17.0.32",
-    "@typescript-eslint/eslint-plugin": "^7.8.0",
-    "@typescript-eslint/parser": "^7.8.0",
-    "concurrently": "^8.2.2",
-    "eslint": "^8.57.0",
+    "@types/node": "^18.19.64",
+    "@types/yargs": "^17.0.33",
+    "@typescript-eslint/eslint-plugin": "^8.13.0",
+    "@typescript-eslint/parser": "^8.13.0",
+    "concurrently": "^9.1.0",
+    "eslint": "^8.57.1",
     "eslint-config-prettier": "^9.1.0",
-    "eslint-import-resolver-typescript": "^3.6.1",
-    "eslint-plugin-import": "^2.29.1",
-    "eslint-plugin-n": "^17.4.0",
-    "eslint-plugin-prettier": "^5.1.3",
-    "eslint-plugin-simple-import-sort": "^12.1.0",
-    "eslint-plugin-typescript-sort-keys": "^3.2.0",
-    "prettier": "^3.2.5",
-    "typescript": "^5.4.5"
+    "eslint-import-resolver-typescript": "^3.6.3",
+    "eslint-plugin-import": "^2.31.0",
+    "eslint-plugin-n": "^17.13.1",
+    "eslint-plugin-prettier": "^5.2.1",
+    "eslint-plugin-simple-import-sort": "^12.1.1",
+    "eslint-plugin-typescript-sort-keys": "^3.3.0",
+    "prettier": "^3.3.3",
+    "typescript": "^5.6.3"
   },
   "engines": {
     "node": "18.* || >= 20"

diff --git a/packages/ember-render-helpers/.eslintrc.js b/packages/ember-render-helpers/.eslintrc.js
@@ -48,19 +48,25 @@ module.exports = {
       rules: {
         '@typescript-eslint/array-type': 'error',
         '@typescript-eslint/consistent-type-imports': 'error',
-        '@typescript-eslint/no-empty-interface': 'off',
+        '@typescript-eslint/no-empty-object-type': [
+          'error',
+          {
+            allowInterfaces: 'always',
+            allowObjectTypes: 'always',
+          },
+        ],
         '@typescript-eslint/no-import-type-side-effects': 'error',
       },
     },
     {
-      files: ['**/*.gts'],
+      files: ['**/*.gjs'],
       parser: 'ember-eslint-parser',
-      extends: ['plugin:ember/recommended-gts'],
+      extends: ['plugin:ember/recommended-gjs'],
     },
     {
-      files: ['**/*.gjs'],
+      files: ['**/*.gts'],
       parser: 'ember-eslint-parser',
-      extends: ['plugin:ember/recommended-gjs'],
+      extends: ['plugin:ember/recommended-gts'],
     },
     {
       files: ['**/*.{gjs,gts,js,ts}'],

diff --git a/packages/ember-render-helpers/package.json b/packages/ember-render-helpers/package.json
@@ -62,42 +62,41 @@
     "test": "echo 'A v2 addon does not have tests, run tests in test-app'"
   },
   "dependencies": {
-    "@embroider/addon-shim": "^1.8.7",
-    "decorator-transforms": "^1.2.1"
+    "@embroider/addon-shim": "^1.9.0",
+    "decorator-transforms": "^2.3.0"
   },
   "devDependencies": {
-    "@babel/core": "^7.24.5",
-    "@babel/plugin-transform-typescript": "^7.24.5",
-    "@babel/runtime": "^7.24.5",
-    "@embroider/addon-dev": "^4.3.1",
-    "@glint/core": "^1.4.0",
-    "@glint/environment-ember-loose": "^1.4.0",
-    "@glint/environment-ember-template-imports": "^1.4.0",
-    "@glint/template": "^1.4.0",
+    "@babel/core": "^7.26.0",
+    "@babel/plugin-transform-typescript": "^7.25.9",
+    "@babel/runtime": "^7.26.0",
+    "@embroider/addon-dev": "^6.0.1",
+    "@glint/core": "^1.5.0",
+    "@glint/environment-ember-loose": "^1.5.0",
+    "@glint/environment-ember-template-imports": "^1.5.0",
+    "@glint/template": "^1.5.0",
     "@rollup/plugin-babel": "^6.0.4",
-    "@tsconfig/ember": "^3.0.6",
-    "@types/ember__component": "^4.0.22",
-    "@types/ember__debug": "^4.0.8",
-    "@typescript-eslint/eslint-plugin": "^7.8.0",
-    "@typescript-eslint/parser": "^7.8.0",
-    "babel-plugin-ember-template-compilation": "^2.2.2",
-    "concurrently": "^8.2.2",
+    "@tsconfig/ember": "^3.0.8",
+    "@typescript-eslint/eslint-plugin": "^8.13.0",
+    "@typescript-eslint/parser": "^8.13.0",
+    "babel-plugin-ember-template-compilation": "^2.3.0",
+    "concurrently": "^9.1.0",
+    "ember-source": "~5.12.0",
     "ember-template-lint": "^6.0.0",
     "ember-template-lint-plugin-prettier": "^5.0.0",
-    "eslint": "^8.57.0",
+    "eslint": "^8.57.1",
     "eslint-config-prettier": "^9.1.0",
-    "eslint-import-resolver-typescript": "^3.6.1",
-    "eslint-plugin-ember": "^12.0.2",
-    "eslint-plugin-import": "^2.29.1",
-    "eslint-plugin-n": "^17.4.0",
-    "eslint-plugin-prettier": "^5.1.3",
-    "eslint-plugin-qunit": "^8.1.1",
-    "eslint-plugin-simple-import-sort": "^12.1.0",
-    "eslint-plugin-typescript-sort-keys": "^3.2.0",
-    "prettier": "^3.2.5",
-    "rollup": "^4.17.2",
+    "eslint-import-resolver-typescript": "^3.6.3",
+    "eslint-plugin-ember": "^12.3.1",
+    "eslint-plugin-import": "^2.31.0",
+    "eslint-plugin-n": "^17.13.1",
+    "eslint-plugin-prettier": "^5.2.1",
+    "eslint-plugin-qunit": "^8.1.2",
+    "eslint-plugin-simple-import-sort": "^12.1.1",
+    "eslint-plugin-typescript-sort-keys": "^3.3.0",
+    "prettier": "^3.3.3",
+    "rollup": "^4.25.0",
     "rollup-plugin-copy": "^3.5.0",
-    "typescript": "^5.4.5"
+    "typescript": "^5.6.3"
   },
   "engines": {
     "node": "18.* || >= 20"

diff --git a/packages/ember-render-helpers/src/helpers/did-update-helper.ts b/packages/ember-render-helpers/src/helpers/did-update-helper.ts
@@ -39,7 +39,6 @@ export default class DidUpdateHelperHelper extends Helper<DidUpdateHelperSignatu
 
       // Consume individual properties to entangle tracking.
       // https://github.com/emberjs/ember.js/issues/19277
-      // eslint-disable-next-line @typescript-eslint/no-empty-function
       positional.forEach(() => {});
       Object.values(named);
 

diff --git a/packages/ember-render-helpers/unpublished-development-types/index.d.ts b/packages/ember-render-helpers/unpublished-development-types/index.d.ts
@@ -3,12 +3,12 @@
 
 import '@glint/environment-ember-loose';
 import '@glint/environment-ember-template-imports';
+import 'ember-source/types';
 
 import type EmberRenderHelpersRegistry from '../src/template-registry.ts';
 
 declare module '@glint/environment-ember-loose/registry' {
   // Remove this once entries have been added! 👇
-  // eslint-disable-next-line @typescript-eslint/no-empty-interface
   export default interface Registry extends EmberRenderHelpersRegistry {
     // Add any registry entries from other addons here that your addon itself uses (in non-strict mode templates)
     // See https://typed-ember.gitbook.io/glint/using-glint/ember/using-addons