Support Mobiledoc 0.3.2 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mixonic
suggested changes
Jul 16, 2019
lib/utils/element-utils.js
Outdated
| element.dataset[name] = value; | ||
| } else { | ||
| const dataName = `data-${dasherize(name)}`; | ||
| return element.setAttribute(dataName, value); |
There was a problem hiding this comment.
✂️ return
Suggested change
| return element.setAttribute(dataName, value); | |
| element.setAttribute(dataName, value); |
mixonic
approved these changes
Jul 16, 2019
| ] | ||
| [MARKUP_MARKER_TYPE, openedMarkups, closedMarkups, text] | ||
| ], | ||
| objectToSortedKVArray(attributes) |
There was a problem hiding this comment.
The optional section attribute value should only be in this array if the version of mobiledoc is 0.3.2, if 0.3.1 or earlier it should not be present at all. This will ensure the tests are still testing old 0.3.1 docs, which we really care about continuing to support/test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues work from #59.
style="text-align: center;"attribute on the DOM element, I'd be more in favor of simply adding adata-md-text-align="center"attribute, and leave it up to the client to implement the styling. Most likely, they will use rules like[data-md-text-align="center'] { text-align: center; }in their CSS, but at least this gives them the flexibility to implement their own styling. Additionally, it makes it easier to query for elements with a certain alignment in the DOM. Note that the Quill editor does something similar, although they add aql-align-centerCSS class on the element.