[BUGFIX] up/down arrows in Firefox should not update mobiledoc #351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox fires
keypress
events for up/down arrows (Chrome, Safari and IE11 do not), andKey#isPrintable
was incorrectly returning true for these events becauseString.fromCharCode(0).length > 0
. This updatesKey#isPrintable
to return false when the source event was an arrow keypress.