Fix bug #395: Error when adding a selection outside the editor while not editing

src/js/editor/editor.js

@@ -66,7 +66,7 @@ const CALLBACK_QUEUES = {
 };
 
 /**
- * The Editor is a core component of mobiledoc-kit. After instantiating 
+ * The Editor is a core component of mobiledoc-kit. After instantiating
  * an editor, use {@link Editor#render} to display the editor on the web page.
  *
  * An editor uses a {@link Post} internally to represent the displayed document.
@@ -409,14 +409,16 @@ class Editor {
    * @private
    */
   _notifyRangeChange() {
-    this._resetRange();
-    this._editState.reset();
+    if (this.isEditable) {
+      this._resetRange();
+      this._editState.reset();
 
-    if (this._editState.rangeDidChange()) {
-      this._rangeDidChange();
-    }
-    if (this._editState.inputModeDidChange()) {
-      this._inputModeDidChange();
+      if (this._editState.rangeDidChange()) {
+        this._rangeDidChange();
+      }
+      if (this._editState.inputModeDidChange()) {
+        this._inputModeDidChange();
+      }
     }
   }
 

tests/acceptance/editor-selections-test.js

@@ -57,6 +57,26 @@ test('selecting across sections is possible', (assert) => {
   assert.equal(editor.activeSections.length, 2, 'selects 2 sections');
 });
 
+test('when editing is disabled, the selection detection code is disabled', (assert) => {
+  $('#qunit-fixture').append('<p>outside section</p>');
+
+  editor = new Editor({mobiledoc: mobileDocWithSection});
+  editor.render(editorElement);
+  editor.disableEditing();
+
+  const firstSection = $('p:contains(one trick pony)')[0];
+  const outsideSection = $('p:contains(outside section)')[0];
+
+  Helpers.dom.selectText(editor ,'trick', firstSection,
+                         'outside', outsideSection);
+
+  Helpers.dom.triggerEvent(document, 'mouseup');
+
+  assert.equal(editor.activeSections.length, 0, 'no selection inside the editor');
+  const selectedText = Helpers.dom.getSelectedText();
+  assert.ok(selectedText.indexOf('trick pony') !== -1 && selectedText.indexOf('outside') !== -1, 'selects the text');
+});
+
 test('selecting an entire section and deleting removes it', (assert) => {
   editor = new Editor({mobiledoc: mobileDocWith2Sections});
   editor.render(editorElement);