Use '__has-no-content' class name to display placeholder text #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes the placeholder to appear even when the editor div is not
wholly devoid of elements.
Possible BREAKING CHANGE: The placeholder text is now absolutely
positioned (at `top: 0`) of the editor div. If a user has applied their
own padding to the editor div the placeholder may not show up in the
correct location. The solution is to add a CSS rule that overrides the
`top` to match the value of the `padding-top`:
```
.__mobiledoc-editor.__has-no-content:after {
top: <value of padding-top>;
}
```
Also: The editor now has a `min-height: 1em;`
to ensure that the placeholder has a space in which to be displayed.
Fixes #407 #171
bantic
force-pushed
the
ensure-placeholder-appears-on-empty-content
branch
from
0a56540 to
764347c
Compare
|
released in |
This was referenced Aug 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes the placeholder to appear even when the editor div is not
wholly devoid of elements.
Possible BREAKING CHANGE: The placeholder text is now absolutely
positioned (at
top: 0) of the editor div. If a user has applied theirown padding to the editor div the placeholder may not show up in the
correct location. The solution is to add a CSS rule that overrides the
topto match the value of thepadding-top:Also: The editor now has a
min-height: 1em;to ensure that the placeholder has a space in which to be displayed.
Fixes #407 #171