Typescriptify Phase IV 💃🕺 #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeeJab
force-pushed
the
zeejab/typescript-phase-4
branch
2 times, most recently
from
d716718
to
37e87e4
Compare
ZeeJab
force-pushed
the
zeejab/typescript-phase-4
branch
from
37e87e4
to
889857b
Compare
tomdale
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is Phase 4 of migrating the mobiledoc-kit lib to typescript. The primary focus here was the parsers.
Additionally, while doing this work, I discovered that the legacy image section did not have
clone()implemented, which is bug. This bug was not caught previously because there were no tests for it. I fixed the bug, and added a test... however, the test is failing in Safari due to unusual behavior in selection management that differs from Chrome and Firefox.I'm skipping the test for now, and we can either remove the image section in an upcoming refactor (which was part of the road to 1.0 plan from the beginning) or find a fix for the Safari bug.