Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting RemoteImageView.imageURL with value of nil returns a ":" #249

Closed
Fritiof opened this issue May 2, 2018 · 1 comment
Closed

setting RemoteImageView.imageURL with value of nil returns a ":" #249

Fritiof opened this issue May 2, 2018 · 1 comment

Comments

@Fritiof
Copy link

Fritiof commented May 2, 2018

Hello,

When initializing our SettingsViewController we set the users avatar from a store containing user information. The users image url property might be nil, and if it is and that is set on a RemoteImageView's imageURL and then read, the resulting value is a semi colon.

image

  • Siesta (1.3.0):
    • Siesta/Core (= 1.3.0)
  • Siesta/Core (1.3.0)
  • Siesta/UI (1.3.0):
    • Siesta/Core
@pcantrell
Copy link
Member

Siesta internally normalizes all invalid URLs to ":", a syntactically valid but never functional URL, in order to funnel URL formatting errors through the same error event mechanism as other resource errors.

This is leaking out through RemoteImageView, and I agree that it shouldn’t!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants