-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return Int64 from IO#write (Crystal 0.35) #3
Conversation
@jgillich Thanks! Looks good to me. I'm surprised it actually still compiles on 0.33.0 (that's what CircleCI uses). |
@@ -2,17 +2,23 @@ require "openssl" | |||
|
|||
class Rucksack | |||
class NotFound < Exception; end | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fan of these blank lines, but if that's what crystal format
wants then, oh well, probably easier to keep them than to argue
with it every time... ;)
@m-o-e Done |
@jgillich Wanna give that a tackle, too? 😬 |
Also renamed the method on Checksummer, not sure if that makes sense or not 🤔 |
Yes it does. Thanks a lot, looks great! 🙇 Will merge, add |
Ah, you should also set |
Yes, I've updated it. Release is out now, please let me know in case you |
Will do, thanks! |
See crystal-lang/crystal#9454
Automatic formatting also did some stuff, I can get rid of that if you don't like it