Better Configuration UX #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 3, 2021 12:09
…aN RenderService values
butlerx
requested changes
Jul 20, 2021
butlerx
force-pushed
the
main
branch
3 times, most recently
from
8976055 to
c897f2f
Compare
Christian7573
force-pushed
the
better_options_ux
branch
from
419fcfb to
a76e700
Compare
Christian7573
force-pushed
the
better_options_ux
branch
from
1cd0797 to
8b3c7d4
Compare
|
Interesting to note: typescript/eslint-plugin 2.5.0 is no longer available from npm and only available through yarn. |
butlerx
reviewed
Aug 25, 2021
| @@ -1,7 +1,7 @@ | |||
| import _ from 'lodash'; | |||
|
|
|||
| export function loadOptions(): object { | |||
| const defaultOptions = { fontSize: 14 }; | |||
| export function loadOptions(): any { | |||
There was a problem hiding this comment.
I believe TS didn't like me indexing/using properties from type object, however changing it back to object now does not bring that error up. Will revert.
To have a hard boundary for CSS and JS since it's neither using SCSS nor bundled TS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan on embedding wetty in a project of mine and looked into changing the color theme. While the previous editor allowed changing the color theme, it was very clunky to use, needing to ready XTerm documentation to find property names and then painfully edit a tiny JSON window on my phone. I've replaced it with a simple field-value editor and copied over all of the options listed in XTerm's documentation. It looks like you have this project set up in a very specific way, so I've done my best to keep it isolated in the assets folder using vanilla HTML, CSS, and JS.