ignore handled errors when creating spaces (cs3org#2439)

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic · Feb 14, 2022 · 1ed9c9f · 1ed9c9f
1 parent 8a956f3
commit 1ed9c9f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/changelog/unreleased/ignore-known-erros.md b/changelog/unreleased/ignore-known-erros.md
@@ -0,0 +1,5 @@
+Enhancement: ignore handled errors when creating spaces
+
+The CreateStorageSpace no longer logs all error cases with error level logging
+
+https://github.com/cs3org/reva/pull/2439
diff --git a/internal/grpc/services/storageprovider/storageprovider.go b/internal/grpc/services/storageprovider/storageprovider.go
@@ -507,13 +507,13 @@ func (s *service) CreateStorageSpace(ctx context.Context, req *provider.CreateSt
 			st = status.NewAlreadyExists(ctx, err, "already exists")
 		default:
 			st = status.NewInternal(ctx, "error listing spaces")
+			appctx.GetLogger(ctx).
+				Error().
+				Err(err).
+				Interface("status", st).
+				Interface("request", req).
+				Msg("failed to create storage space")
 		}
-		appctx.GetLogger(ctx).
-			Error().
-			Err(err).
-			Interface("status", st).
-			Interface("request", req).
-			Msg("failed to create storage space")
 		return &provider.CreateStorageSpaceResponse{
 			Status: st,
 		}, nil