decomposedfs: do not swallow errors when creating nodes (cs3org#2457)

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic · Feb 14, 2022 · a955d62 · a955d62
1 parent 4f84896
commit a955d62
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/changelog/unreleased/do-not-swallow-error.md b/changelog/unreleased/do-not-swallow-error.md
@@ -0,0 +1,5 @@
+Bugfix: do not swallow error
+
+decomposedfs not longer swallows errors when creating a node fails.
+
+https://github.com/cs3org/reva/pull/2457
diff --git a/pkg/storage/utils/decomposedfs/tree/tree.go b/pkg/storage/utils/decomposedfs/tree/tree.go
@@ -259,7 +259,7 @@ func (t *Tree) CreateDir(ctx context.Context, n *node.Node) (err error) {
 
  err = t.createNode(n, owner)
  if err != nil {
- return nil
+ return
  }
 
  // make child appear in listings