Do not log nodes (cs3org#2463)

* Do not log whole nodes It turns out that logging whole node objects is very expensive and also spams the logs quite a bit. Instead we just log the node ID now. * Add changelog
butonic · Feb 14, 2022 · d07d63e · d07d63e
1 parent c68b5cd
commit d07d63e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/changelog/unreleased/do-not-log-nodes.md b/changelog/unreleased/do-not-log-nodes.md
@@ -0,0 +1,6 @@
+Enhancement: do not log whole nodes
+
+It turns out that logging whole node objects is very expensive and also
+spams the logs quite a bit. Instead we just log the node ID now.
+
+https://github.com/cs3org/reva/pull/2463
diff --git a/pkg/storage/utils/decomposedfs/node/node.go b/pkg/storage/utils/decomposedfs/node/node.go
@@ -506,7 +506,7 @@ func (n *Node) SetFavorite(uid *userpb.UserId, val string) error {
 
 // AsResourceInfo return the node as CS3 ResourceInfo
 func (n *Node) AsResourceInfo(ctx context.Context, rp *provider.ResourcePermissions, mdKeys []string, returnBasename bool) (ri *provider.ResourceInfo, err error) {
- sublog := appctx.GetLogger(ctx).With().Interface("node", n).Logger()
+ sublog := appctx.GetLogger(ctx).With().Interface("node", n.ID).Logger()
 
  var fn string
  nodePath := n.InternalPath()