Merge pull request #1375 from Johann-S/fix/create-group

fix(groups): allow to create a group with no parent
buttercup · Sep 8, 2024 · aa914b7 · aa914b7
2 parents 7ca0126 + c540c01
commit aa914b7
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/source/renderer/components/vault/GroupsList.tsx b/source/renderer/components/vault/GroupsList.tsx
@@ -215,9 +215,6 @@ export const GroupsList = () => {
         if (groupEditID !== null && groupEditID !== -1) {
             onRenameGroup(groupEditID, newGroupName);
         } else {
-            if (!parentGroupID) {
-                throw new Error("No parent ID specified");
-            }
             onCreateGroup(parentGroupID, newGroupName);
         }
         closeEditDialog();

diff --git a/source/renderer/components/vault/VaultContext.tsx b/source/renderer/components/vault/VaultContext.tsx
@@ -37,7 +37,7 @@ export interface VaultContextState {
 
     batchDeleteItems: (action: { groupIDs?: Array<GroupID>; entryIDs?: Array<EntryID>; }) => void;
     onCollapseGroup: (group: GroupTreeNodeInfo) => void;
-    onCreateGroup: (parentID: GroupID, groupTitle: string) => void;
+    onCreateGroup: (parentID: GroupID | null, groupTitle: string) => void;
     onExpandGroup: (group: GroupTreeNodeInfo) => void;
     onSelectGroup: (groupID: GroupID | null) => void;
     onGroupFilterTermChange: (term: string) => void;