-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency updates #79
Conversation
Upgrade react-native
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great mate. Just two small things :)
@@ -8,7 +8,7 @@ import { | |||
isConnecting | |||
} from "../selectors/RemoteConnectPage.js"; | |||
import { | |||
getNotification as getDropboxAuthNotification, | |||
// getNotification as getDropboxAuthNotification, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra comment here
archiveType: getArchiveType(state), | ||
connecting: isConnecting(state), | ||
dropboxAuthenticated: isAuthenticated(state), | ||
// dropboxAuthMessage: getDropboxAuthNotification(state), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here too
Sorted mate! @sallar |
Update some critical dependencies, React (16), React Native (0.54).
Dependencies before merging:
Invalid response for blob
facebook/react-native#18223 - "Invalid response for blob" errorBackground colour for icons/images(will be solved in a later MR)Fixes #74 (Unable to install dependencies).