Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency updates #79

Merged
merged 18 commits into from
Apr 4, 2018
Merged

Dependency updates #79

merged 18 commits into from
Apr 4, 2018

Conversation

perry-mitchell
Copy link
Member

@perry-mitchell perry-mitchell commented Mar 11, 2018

Update some critical dependencies, React (16), React Native (0.54).

Dependencies before merging:

Fixes #74 (Unable to install dependencies).

@perry-mitchell perry-mitchell self-assigned this Mar 11, 2018
@perry-mitchell perry-mitchell changed the title WIP: Dependency updates Dependency updates Apr 4, 2018
Copy link
Member

@sallar sallar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great mate. Just two small things :)

@@ -8,7 +8,7 @@ import {
isConnecting
} from "../selectors/RemoteConnectPage.js";
import {
getNotification as getDropboxAuthNotification,
// getNotification as getDropboxAuthNotification,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra comment here

archiveType: getArchiveType(state),
connecting: isConnecting(state),
dropboxAuthenticated: isAuthenticated(state),
// dropboxAuthMessage: getDropboxAuthNotification(state),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here too

@perry-mitchell
Copy link
Member Author

Sorted mate! @sallar

@perry-mitchell perry-mitchell merged commit fe5bd24 into master Apr 4, 2018
@perry-mitchell perry-mitchell deleted the dependency_update branch April 4, 2018 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to install dependencies
2 participants