Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/pots #28

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

F/pots #28

wants to merge 16 commits into from

Conversation

lajarre
Copy link
Member

@lajarre lajarre commented Jan 15, 2023

Spec - sequence diagram

image

Todo

  • mToken minting
  • cooldown management
  • Campaign launch: takeOffice
  • Campaign launch: terminate Election

#29
#30
#31
#32

Caveats

Terms may be out of date.

@lajarre lajarre force-pushed the f/pots branch 3 times, most recently from 85727ef to 0e42a74 Compare January 31, 2023 12:16
@lajarre lajarre force-pushed the f/pots branch 3 times, most recently from 7cc3603 to 26c02ed Compare February 8, 2023 12:52
Comment on lines +51 to +53
address public representative;
MoltenElection public election;
MToken public mToken;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can further enforce immutability of these system variables by adding the immutable modifier to these variables:

    address public immutable representative;
    MoltenElection public immutable election;
    MToken public immutable mToken;

also:

Compared to regular state variables, the gas costs of constant and immutable variables are much lower.
Immutable variables are evaluated once at construction time and their value is copied to all the places in the code where they are accessed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants