Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd love to be able to add Carthage support. I notice that there was a previous PR (#120) that seems to have stalled. Not sure if that is because the changes are not acceptable, or just look intimidating due to the
xcodeproj
file format.Anyway, this PR is slightly less large as it doesn't play with the umbrella header or the module map. I've also been very deliberate in how I've broken the commits up so you can see the specific changes that have been made along the way. Specifically, this is what I did:
DeepLinkKit
DeepLinkKit
with a new file calledInfo.plist
and a reference to the existingDeepLinkKit.h
. All I did was move the reference toInfo.plist
into the existing group of the same name, remove the duplicate reference to the.h
file, and remove the duplicate group. Purely housekeeping to make the navigator look neat..m
files and added them to the newly created target.h
files referenced in theDeepLinkKit.h
umbrella header and made sure they were marked as public so they get copied into theDeepLinkKit.framework/Headers
folderSo, even though the
project.pbxproj
has loads of changes, hopefully you can see from the above, they are pretty contained.