-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carthage support #134
Carthage support #134
Conversation
…t into the existing DeepLinkKit group
Hi @edwardaux, It looks like you haven't signed our Contributor License Agreement, yet.
Please read and sign our full Contributor License Agreement here. Once you've signed reply with Thank you, ButtonBot |
Have signed contributor license. [clabot:check] |
Nice @edwardaux! We’ll take a look quickly and try to get this merged! 😄😄 |
Thanks @edwardaux! This looks great–really appreciate the thoroughness! fixes #120 |
I'd love to be able to add Carthage support. I notice that there was a previous PR (#120) that seems to have stalled. Not sure if that is because the changes are not acceptable, or just look intimidating due to the
xcodeproj
file format.Anyway, this PR is slightly less large as it doesn't play with the umbrella header or the module map. I've also been very deliberate in how I've broken the commits up so you can see the specific changes that have been made along the way. Specifically, this is what I did:
DeepLinkKit
DeepLinkKit
with a new file calledInfo.plist
and a reference to the existingDeepLinkKit.h
. All I did was move the reference toInfo.plist
into the existing group of the same name, remove the duplicate reference to the.h
file, and remove the duplicate group. Purely housekeeping to make the navigator look neat..m
files and added them to the newly created target.h
files referenced in theDeepLinkKit.h
umbrella header and made sure they were marked as public so they get copied into theDeepLinkKit.framework/Headers
folderSo, even though the
project.pbxproj
has loads of changes, hopefully you can see from the above, they are pretty contained.