Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Component two character at least #144

Closed
wants to merge 1 commit into from
Closed

Fix Component two character at least #144

wants to merge 1 commit into from

Conversation

gaizhi
Copy link

@gaizhi gaizhi commented Apr 4, 2018

BUGFIX fix when route like “/say/:a/:b”, the route would not/say/:a/:b, because DPLNamedGroupComponentPattern ask for at least two
character

BUGFIX fix when route like “/say/:a/:b”, the route would not
fb54347 
    /say/:a/:b, because DPLNamedGroupComponentPattern ask for at least two
    character
@button-bot
Copy link

Hi @gaizhi,
Thank you for your Pull Request!

It looks like you haven't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen license.
Wikipedia

Please read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to let us know.

Thank you,

ButtonBot

@gaizhi
Copy link
Author

gaizhi commented Apr 8, 2018

[clabot:check]

@button-bot
Copy link

@wessmith It looks like @gaizhi just signed our Contributor License Agreement. 👍

ButtonBot

wessmith
wessmith requested changes Apr 25, 2018
View reviewed changes
Copy link
Member

@wessmith wessmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gaizhi . Could you please add a test for this scenario?

@wessmith wessmith mentioned this pull request May 31, 2019
Merged
@wessmith
Copy link
Member

Merged in #152

@wessmith wessmith closed this May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wessmith wessmith wessmith requested changes

@chrismaddern chrismaddern Awaiting requested review from chrismaddern

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaizhi @button-bot @wessmith