Add a Swift Receiver Demo #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -48,6 +48,8 @@ | |||
| <key>UISupportedInterfaceOrientations</key> | |||
| <array> | |||
| <string>UIInterfaceOrientationPortrait</string> | |||
| <string>UIInterfaceOrientationLandscapeLeft</string> | |||
There was a problem hiding this comment.
I have no idea why or how that got in there! Let me remove that.
| import Foundation | ||
|
|
||
| public class DPLMessageRouteHandler: DPLRouteHandler | ||
| { |
There was a problem hiding this comment.
Switching between same & next line open braces in this file ;)
|
@platedbay A couple stylistic consistency nitpicks but I'm excited to get this merged! :) |
|
Nice, let's wait for tests to pass then LGTM |
|
👍 |
|
As a side-note, anything you come across as you build on DLK on Swift, feel free to open an issue - I'd love to make it better in any way we can. |
|
Will do! |
chrismaddern
added a commit
that referenced
this pull request
Jul 16, 2015
Add a Swift Receiver Demo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a simple example of how to use the DeepLinkKit in Swift. As of creating this PR, the only way to handle routes is by creating classes that subclasses the
DPLRouteHandlerclass. This was requested in #65.In order to support the shorthand approach of registering a
DPLRouteHandlerBlockto a route, we'd need (I believe) to enhance the library a bit more (create a sort of class/struct that has theDPLRouteHandlerBlockas a property would be a potential solution). This is out of scope of this PR as per #28.I can also create a Swift version of the SenderDemo; however, there aren't many changes involved with that one. Let me know what you guys think!