Preserve query items without a value #73
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #72
Technically keys missing values in a query string are legit (rfc3986) and we prefer when a url is parsed into a
DPLDeepLink
it is serialized into the same url.Additionally note that
NSURL
interprets and preserves query data that is not complete key value pairs.For example:
Currently DeepLinkKit will discard
foo
in this situation. This change set preserves the value as a key in-[DPLDeepLink queryParameters]
with a placeholder value. Upon serialization, the key is placed back in the query of the URL with no value.e.g. The query parameters of the url
http://example.com?foo&bar=baz
is represented as:serializing the deep link
deepLink.URL
restores the query to the same state.