Adds sample app #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be a good opportunity for someone who has not been working on mParticle related tasks to try and deploy, edit, and test the project. |
ecgreb
commented
Sep 14, 2018
sample/src/main/AndroidManifest.xml
Outdated
|
|
||
| <application | ||
| android:name=".SampleApplication" | ||
| android:allowBackup="true" |
There was a problem hiding this comment.
Let's switch to false so uninstalling actually clears data 😂
sample/README.md
Outdated
| @@ -34,4 +34,5 @@ If you recently issued new credentials, try re-installing the sample app as the | |||
| Confirm the following: | |||
| 1. The proper package name (e.g. `com.example.buttonkit`) is shown in the mParticle Dashboard. | |||
| 2. There exists an input (the sample/test app) and an output (Button integration from mParticle marketplace) and that it is active. | |||
| 3. The Button integration is configured properly with a valid [Application ID](https://app.usebutton.com/account/login/?next=/settings/organization) | |||
| 3. The Button integration is configured properly with a valid [Application ID](https://app.usebutton.com/account/login/?next=/settings/organization). | |||
There was a problem hiding this comment.
Can we specify where the Button App id is configured (i.e. mParticle dashboard)
| @@ -0,0 +1,7 @@ | |||
| <resources> | |||
| <string name="app_name">ButtonKit Sample</string> | |||
There was a problem hiding this comment.
Let's shorten sample app name to just "ButtonKit" so it doesn't truncate in the launcher app :)
sample/README.md
Outdated
| 1. The proper package name (e.g. `com.example.buttonkit`) is shown in the mParticle Dashboard. | ||
| 2. There exists an input (the sample/test app) and an output (Button integration from mParticle marketplace) and that it is active. | ||
| 3. The Button integration is configured properly with a valid [Application ID](https://app.usebutton.com/account/login/?next=/settings/organization). | ||
| 4. You are not behind a proxy (e.g. Charles Proxy). |
There was a problem hiding this comment.
Thank you for adding this - it definitely got me on the first try!
|
LGTM |
najmsheikh
force-pushed
the
chuck/sample
branch
from
82fa346 to
572f83a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a sample app module to the repo with MParticle & Button Kit integration that can be used for testing and documentation.