Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resync diverged repo #9

Closed
wants to merge 20 commits into from
Closed

Resync diverged repo #9

wants to merge 20 commits into from

Conversation

najmsheikh
Copy link

This repo had diverged from the upstream mParticle Button Kit repo and as such this PR syncs all the changes back.

The first commit 262c32c is simply a rebased commit of work that already exists in this PR. Subsequent commits were made by the mParticle team.

ecgreb and others added 19 commits June 5, 2019 15:42
    - handle missing project.version value
- remove settings.gradle
Bumps button-merchant from 1.0.0 to 1.1.1.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps button-merchant from 1.1.1 to 1.1.2.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
This commit attempts to maintain feature parity with previous ButtonKit
version by interacting with the `KitManager` in the same way on
attribution token changes and on post-install deep links.

* Attribution token changes invoke `setIntegrationAttributes()` on kit
* Post-install deep links no longer start the activity
* Post-install deep links sets `AttributionResult` on kit manager
* No post-install deep link sets `AttributionError` on kit manager
* Debug logging check removed since handled by `Logger.setMinLogLevel()`
* Adds tests for kit manager interactions
@najmsheikh najmsheikh requested a review from paultopher August 20, 2020 18:41
@najmsheikh najmsheikh self-assigned this Aug 20, 2020
@jmcgill
Copy link

jmcgill commented Dec 3, 2020

@najmsheikh seems ready to (and worth!) merging

@najmsheikh najmsheikh closed this Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants