Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buttonmen-dev/buttonmen#2668 enhance python api #2912

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

buttonmen-dev/buttonmen#2668 enhance python api #2912

wants to merge 5 commits into from

Conversation

danlangford
Copy link
Contributor

@danlangford danlangford commented May 20, 2023 •
edited
Loading

#2668

BMAPI.PY

  • search_game_history
  • load_button_data
  • load_forum_thread
  • edit_forum_post
  • submit_chat

BMUTILS.PY

  • wrap_search_game_history
  • wrap_load_button_data
  • wrap_load_forum_thread
  • wrap_edit_forum_post
  • wrap_submit_chat

I added these years ago. I recently merged in #2667 and I think I resolved any major problems. i could have goofed something up. I wanted to get this infant of you all while I go back and triple validate it

QUESTIONS

  • How would you feel about me organizing the members of these entire classes here alphabetically? It would give a little more rhyme and reason to where things belong which will be helpful when adding new api calls.

should I add a couple reviewers? like @blackshadowshade and @cgolubi1

@agathazeren agathazeren mentioned this pull request Mar 8, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danlangford