ButtplugFutureStateShared: fix send/sync impl #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Ok, thanks! Bringing this into dev and it should go out with the next bugfix release today. I really need to sit down and get a handle on Sync/Send and my futures setup at some point. Just gotta finish firefighting first. :| |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 🦀,
I had previously suggested a fix to the
Send/Syncimpl ofButtplugFutureStateSharedin #225,and the fix was made in 3199bd8 .
However @Qwaz pointed out in #225 (comment) that
part of the suggestion I had made was incorrect, and this PR is to make a follow-up fix.
After the fix, the requirement for
ButtplugFutureStateShared<T>to beSyncbecomesT: Sendinstead ofT: Sync.(via auto trait implementations)
Sorry for the mistake I made in my previous suggestion,
and thank you for reviewing this PR 👍