-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"index out of bounds", when cycling past the outer columns #96
Comments
Thanks for reporting! |
Unable to replicate on my end as of yet. Are you running with nvidia/graphics support? |
Without, I don't have the optional "nvidia-tools" installed. To be clear, I was just trying this tool out for fun, to compare Rust-based tool alternatives. But I moved on in the meantime. (No hard feelings, I hope... ;) ) I reported it hoping that it would be helpful to you. But for reference, I just did another clean install (without nvidia support) and was able to reproduce the same behavior instantly. |
Thanks for getting back to me. And no, no hard feelings :). I appreciate you took to the time to make an issue and for trying another install! |
Hey, I can reproduce the issue. No nvidia GPU here. zenith panics if you jump
thread '<unnamed>' panicked at 'index out of bounds: the len is 12 but the index is 12', src/render.rs:314:5
thread '<unnamed>' panicked at 'index out of bounds: the len is 12 but the index is 13', src/render.rs:314:5 (I'm the maintainer of the aforementioned AUR |
Thanks for letting me know. What version are you running ? |
Latest release, 0.12.0: https://dl.bintray.com/bvaisvil/debian/pool/z/zenith/zenith_0.12.0-1_amd64.deb |
Possible for you to try building it from source (master branch) and see if it still happens for you? |
It cycles as expected with current master 6f09825 |
great! Thank you for testing and letting me know. I'll work on making a new release. |
@murlakatamenka Thanks for reporting! I'll take a look. |
Does it panic instantly, or only while cycling? If it panics while you're cycling the table, could you tell me what columns you have? |
Okay, I think I've figured this out. The deb package is built on a docker image with the So I think at least three things need to be done -
|
I've made a new deb package that contains the fixes in commit 897364e. In my testing this fixed the issue. Would very much appreciate it if you could give it a try and see if it works for you. New Deb file: |
Yes, it was only when cycling. Your guess should be right because I don't run Nvidia GPU and don't have its drivers installed. The binary from attached .deb works without panicking 👍 As a side note it still shows an empty "Graphics" group, it takes space for no reason. |
Updated to hide the 'Graphics' group to hide if no cards are detected. Could you try this and check to see if that works and if it still doesn't crash. Thanks! |
When I press
.
or,
in the task panel, to move the selected column past the first/last column, the application fails with the following "index out of bounds"-message:The issue can be reproduced consistently.
I'm running
zenith 0.12.0
, from the "zenith-bin" AUR package.The text was updated successfully, but these errors were encountered: