-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow zenith to start when another instance is running, and add warnings #109
Conversation
Thank you very much for the PR. This is looking good, I'd like just a few changes though:
Thank you for your contributions and interest! |
I've tried several layout changes, and Ultimately, I'd like to add scrolling and a scroll indicator, which will also be useful for the per-process view when the arguments don't fit on one screen (as is often the case for rustc). |
Removing the margins is fine by me. Let me know when I should give this another test! |
Well I did push the changes that remove the margin right before posting that comment, so this should be it, ready to test. |
Okay, thanks for the updates. I very much appreciate your contributions! I tested the new commits and unfortunately found a few issues though that will need to be fixed:
|
…ng. Add warnings to this effect
Hiya, looks like you've addresses all of the issues I've identified. Were you planning any more changes or should I merge this in? |
I was planning on trying to see why there may be a long startup time, but for some reason it doesn't happen on my machine, so I can't measure what's taking it. Other than that I had nothing more planned for this PR. |
@bvaisvil So in the end, if you can provide me with some precise measurement of exactly which lines take a long time at startup, I can probably fix it. But since I can't see the startup delay myself, I have nothing to add. As a few other issues in the past, maybe this is also something that depends on OSX. |
Actually, I'm seeing the issue on linux (Fedora) but looks like it only consistently happens with the debug build. So I don't see any reason not to merge. Thanks for the work on this! |
related: #107
Right now, this only starts without writing to the db.
It adds a warning in the top right on the main screen, and an explanation on the help screen.
The wording and formatting of the warnings are subject to bikeshedding :).
I think the original issue could remain open, until a more complete handling for this scenario lands.