Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for multiple budget types, introduced in version 25. #104

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

bvanelli
Copy link
Owner

@bvanelli bvanelli commented Jan 15, 2025

Dynamically resolves the type of budget based on the file configuration. There are now two types of budget to choose from, retrieved from the preferences table:

  • Envelope budgeting (default, recommended): budgetType is rollover, table is ZeroBudgets
  • Tracking budgeting: budgetType is report, table is ReflectBudgets

All budget functions will now respect the globally defined preference when creating/updating budgets.

Closes #103

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.89%. Comparing base (9ee273b) to head (1e2434f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   97.87%   97.89%   +0.02%     
==========================================
  Files          16       16              
  Lines        2258     2283      +25     
==========================================
+ Hits         2210     2235      +25     
  Misses         48       48              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bvanelli bvanelli merged commit d2f2878 into main Jan 16, 2025
7 checks passed
@bvanelli bvanelli deleted the fix/support-tracking-budgets branch January 16, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_budgets appears to only get 1 budget
1 participant