Update X12StreamReader class to fix edge case around ReadNextTransaction. #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2FlatTransaction to be returned. Fix string documentation in X12Parser.
bvanfleet
commented
Jan 13, 2021
Comment on lines
+190
to
+192
| case null: | ||
| // This case is added to handle where EOF is reached with no segments read. | ||
| break; |
Owner
Author
There was a problem hiding this comment.
Unfortunately, this was hit with a lot of minor formatting changes that don't actually change the file. This bit is the core of this PR, where we catch the case where EOF is hit before we read any segments.
apeiris
pushed a commit
to apeiris/X12.NET
that referenced
this pull request
Jan 27, 2021
…anfleet#22 from bvanfleet/u/bvanfleet/documentation Update X12StreamReader class to fix edge case around ReadNextTransaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix edge case in ReadNextTransaction where EOF may cause an invalid X12FlatTransaction to be returned.
Fix string documentation in X12Parser.