Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes invalid argument error on IE #70

Merged
merged 1 commit into from
Dec 2, 2014
Merged

Conversation

chris-hanson
Copy link

Binding on placeholder throws an error on IE11

More info: angular/angular.js/issues/5025

bvaughn added a commit that referenced this pull request Dec 2, 2014
Fixes invalid argument error on IE
@bvaughn bvaughn merged commit 77426b7 into bvaughn:master Dec 2, 2014
@bvaughn
Copy link
Owner

bvaughn commented Dec 2, 2014

Thanks for submitting this patch Chris.

It will go out in the next release, hopefully soon.

@bvaughn
Copy link
Owner

bvaughn commented Dec 3, 2014

Sorry for the long delay, but I'm happy to let you know that 1.6.1 has been released with a fix for this issue. Thanks for your patience!

@chris-hanson
Copy link
Author

Awesome. Thanks. Does this mean you've been given permission to continue working on formFor?

@bvaughn
Copy link
Owner

bvaughn commented Dec 5, 2014

Yup! :)
On Wed, Dec 3, 2014 at 1:31 PM Chris Hanson notifications@github.com
wrote:

Awesome. Thanks. Does this mean you've been given permission to continue
working on formFor?

Reply to this email directly or view it on GitHub
#70 (comment)
.

@DOrlov77
Copy link

DOrlov77 commented Mar 8, 2015

Hi guys,
what about to fix the root of the issue nor result? :)
Making the textarea directive as terminal will fix the issue.

See http://jsfiddle.net/jgz6z50f/

@bvaughn
Copy link
Owner

bvaughn commented Mar 8, 2015

Hey @DOrlov77,

Thanks for the suggestion. What's the benefit of that approach over the current one?

I see one potential downside- decorating textarea (in a global way) like this could have an unexpected impact on formFor users that also use <textarea> for any of their custom inputs. At the effects of the current solution is contained with formFor's template view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants