Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for different time ranges (e.g. days, weeks, months) #11

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

bvaughn
Copy link
Owner

@bvaughn bvaughn commented Jan 4, 2022

  • Replace month-centric index+duration with start/stop date.
  • Scale horizontal axis (and labels) to fit the supplied tasks.
  • Don't mutate dates; store temporal metadata in a Map somewhere.
  • Auto-import and upgrade previous data format from URL.
  • Add e2e tests.
  • Re-consider @js-temporal/polyfill usage (it's pretty large; maybe check dayjs?)

View years example

Screen Shot 2022-01-04 at 3 21 23 PM

View months example

Screen Shot 2022-01-04 at 3 21 28 PM

View weeks example

Screen Shot 2022-01-04 at 3 21 36 PM

View days example

Screen Shot 2022-01-04 at 3 21 43 PM

@bvaughn bvaughn mentioned this pull request Jan 4, 2022
@vercel
Copy link

vercel bot commented Jan 4, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/bvaughn/planner/DLd9qPJFuT7cV3Xdf1m2PmRzKEV2
✅ Preview: https://planner-git-support-units-bvaughn.vercel.app

@bvaughn
Copy link
Owner Author

bvaughn commented Jan 4, 2022

Seeing some e2e snapshot flakiness; reported via microsoft/playwright#11177

@bvaughn bvaughn marked this pull request as ready for review January 4, 2022 20:20
@bvaughn bvaughn merged commit 92d8c34 into main Jan 4, 2022
@bvaughn bvaughn deleted the support-units branch January 4, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant