New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(.github/workflows/ci.yml): remove version field in with of pnpm/action-setup #208

Merged

bvaughn merged 1 commit into bvaughn:master from sukvvon:chore/remove-pnpm-action-setup-version

Dec 21, 2024

Contributor

sukvvon commented Nov 20, 2024

What:

removed the version specified in the with field of pnpm/action-setup.

Why:

pnpm/action-setup automatically recognizes the pnpm version defined in the packageManager field of package.json. specifying the version in the with field is redundant, adds unnecessary complexity, and increases maintenance overhead. relying on the packageManager field ensures simplicity and consistency.

How:

removed the version field from the with configuration in .github/workflows/ci.yml. the pnpm version will now be derived directly from the packageManager field in package.json.

Checklist:

Documentation
Tests
Ready to be merged


          chore(.github/workflows/ci.yml): remove version field in with of pnpm…

3bf96ed

…/action-setup

Contributor Author

sukvvon commented Nov 27, 2024

@bvaughn could you review this pr?

bvaughn approved these changes

View reviewed changes

bvaughn merged commit 5c8d234 into bvaughn:master

3 checks passed

sukvvon deleted the chore/remove-pnpm-action-setup-version branch

December 21, 2024 23:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet