multigrid support onScroll #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaughn
reviewed
Jan 11, 2017
| @@ -433,7 +434,7 @@ export default class MultiGrid extends Component { | |||
| columnCount={columnCount - fixedColumnCount} | |||
| columnWidth={this._columnWidthRightGrid} | |||
| height={this._getBottomGridHeight(props)} | |||
| onScroll={this._onScroll} | |||
| onScroll={(info) => {this._onScroll(info);onScroll && onScroll(info)}} | |||
There was a problem hiding this comment.
How about moving this into the _onScroll method? That way the code's a bit easier to read and we avoid creating a new wrapper function on each render. :)
There was a problem hiding this comment.
Oh right, i thought the _onScroll has been used not only in bottomRight grid, also in other grid. And the passed onScroll only should use in one Grid.
I will update it.
|
Thanks 😄 This will go out in a point release soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multigrid support onScroll