(Build fix) babel-preset-es2015 updates #572

toddtarsi · 2017-02-10T22:02:27Z

When attempting to test locally, I found I could not build on my system.
The command that would fail was npm run build:es.
This was the error I got:


resolve failed:  { Error: Cannot find module 'q-io'
    at Function.Module._resolveFilename (module.js:438:15)
    at Function.requireRelative.resolve (/Users/Eplata/react-virtualized/node_modules/require-relative/index.js:30:17)
    at resolve (/Users/Eplata/react-virtualized/node_modules/modify-babel-preset/lib/serialize.js:25:26)
    at findAndRemove (/Users/Eplata/react-virtualized/node_modules/modify-babel-preset/lib/serialize.js:67:11)
    at /Users/Eplata/react-virtualized/node_modules/modify-babel-preset/lib/serialize.js:111:13
    at Array.map (native)
    at loadPreset (/Users/Eplata/react-virtualized/node_modules/modify-babel-preset/lib/serialize.js:103:29)
    at module.exports (/Users/Eplata/react-virtualized/node_modules/modify-babel-preset/index.js:97:19)
    at Object.<anonymous> (/Users/Eplata/react-virtualized/node_modules/babel-preset-es2015-rollup/index.js:3:18)
    at Module._compile (module.js:541:32) code: 'MODULE_NOT_FOUND' } q-io
node_modules/nan
resolve failed:  { Error: Cannot find module 'collections'
    at Function.Module._resolveFilename (module.js:438:15)
    at Function.requireRelative.resolve (/Users/Eplata/react-virtualized/node_modules/require-relative/index.js:30:17)
    at resolve (/Users/Eplata/react-virtualized/node_modules/modify-babel-preset/lib/serialize.js:25:26)
    at findAndRemove (/Users/Eplata/react-virtualized/node_modules/modify-babel-preset/lib/serialize.js:67:11)
    at /Users/Eplata/react-virtualized/node_modules/modify-babel-preset/lib/serialize.js:111:13
    at Array.map (native)
    at loadPreset (/Users/Eplata/react-virtualized/node_modules/modify-babel-preset/lib/serialize.js:103:29)
    at module.exports (/Users/Eplata/react-virtualized/node_modules/modify-babel-preset/index.js:97:19)
    at Object.<anonymous> (/Users/Eplata/react-virtualized/node_modules/babel-preset-es2015-rollup/index.js:3:18)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:456:32)
    at tryModuleLoad (module.js:415:12)
    at Function.Module._load (module.js:407:3)
    at Module.require (module.js:466:17)
    at require (internal/module.js:20:19) code: 'MODULE_NOT_FOUND' } collections
resolve failed:  { Error: Cannot find module 'caniuse-db'
    at Function.Module._resolveFilename (module.js:438:15)
    at Function.requireRelative.resolve (/Users/Eplata/react-virtualized/node_modules/require-relative/index.js:30:17)
    at resolve (/Users/Eplata/react-virtualized/node_modules/modify-babel-preset/lib/serialize.js:25:26)
    at findAndRemove (/Users/Eplata/react-virtualized/node_modules/modify-babel-preset/lib/serialize.js:67:11)
    at /Users/Eplata/react-virtualized/node_modules/modify-babel-preset/lib/serialize.js:111:13
    at Array.map (native)
    at loadPreset (/Users/Eplata/react-virtualized/node_modules/modify-babel-preset/lib/serialize.js:103:29)
    at module.exports (/Users/Eplata/react-virtualized/node_modules/modify-babel-preset/index.js:97:19)
    at Object.<anonymous> (/Users/Eplata/react-virtualized/node_modules/babel-preset-es2015-rollup/index.js:3:18)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:456:32)
    at tryModuleLoad (module.js:415:12)
    at Function.Module._load (module.js:407:3)
    at Module.require (module.js:466:17)
    at require (internal/module.js:20:19) code: 'MODULE_NOT_FOUND' } caniuse-db
resolve failed:  { Error: Cannot find module 'babel-runtime'
    at Function.Module._resolveFilename (module.js:438:15)
    at Function.requireRelative.resolve (/Users/Eplata/react-virtualized/node_modules/require-relative/index.js:30:17)
    at resolve (/Users/Eplata/react-virtualized/node_modules/modify-babel-preset/lib/serialize.js:25:26)
    at findAndRemove (/Users/Eplata/react-virtualized/node_modules/modify-babel-preset/lib/serialize.js:67:11)
    at /Users/Eplata/react-virtualized/node_modules/modify-babel-preset/lib/serialize.js:111:13
    at Array.map (native)
    at loadPreset (/Users/Eplata/react-virtualized/node_modules/modify-babel-preset/lib/serialize.js:103:29)
    at module.exports (/Users/Eplata/react-virtualized/node_modules/modify-babel-preset/index.js:97:19)
    at Object.<anonymous> (/Users/Eplata/react-virtualized/node_modules/babel-preset-es2015-rollup/index.js:3:18)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:456:32)
    at tryModuleLoad (module.js:415:12)
    at Function.Module._load (module.js:407:3)
    at Module.require (module.js:466:17)
    at require (internal/module.js:20:19) code: 'MODULE_NOT_FOUND' } babel-runtime
resolve failed:  { Error: Cannot find module 'webpack-core'
    at Function.Module._resolveFilename (module.js:438:15)
    at Function.requireRelative.resolve (/Users/Eplata/react-virtualized/node_modules/require-relative/index.js:30:17)
    at resolve (/Users/Eplata/react-virtualized/node_modules/modify-babel-preset/lib/serialize.js:25:26)
    at findAndRemove (/Users/Eplata/react-virtualized/node_modules/modify-babel-preset/lib/serialize.js:67:11)
    at /Users/Eplata/react-virtualized/node_modules/modify-babel-preset/lib/serialize.js:111:13
    at Array.map (native)
    at loadPreset (/Users/Eplata/react-virtualized/node_modules/modify-babel-preset/lib/serialize.js:103:29)
    at module.exports (/Users/Eplata/react-virtualized/node_modules/modify-babel-preset/index.js:97:19)
    at Object.<anonymous> (/Users/Eplata/react-virtualized/node_modules/babel-preset-es2015-rollup/index.js:3:18)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:456:32)
    at tryModuleLoad (module.js:415:12)
    at Function.Module._load (module.js:407:3)
    at Module.require (module.js:466:17)
    at require (internal/module.js:20:19) code: 'MODULE_NOT_FOUND' } webpack-core

While googling some of the keywords on traces, I found this group of stack traces:
developit/preact-boilerplate#89

I basically followed their advice, nothing, and then tried updating these dependencies. That seemed to do it.

Please let me know if you have any thoughts / differences in your experiences.
Thanks again for the excellent repo, and if you'd like any other feedback, let me know!

Node: v6.0.0
Npm: 4.2.0
OS: MacOS Sierra 10.12.1

bvaughn · 2017-02-10T22:32:52Z

Hey @toddtarsi,

Thanks for submitting a patch! That's awesome.

For the dependency bump- I wonder if you would also be willing to update the yarn.lock so that it and package.json stay in sync?

I'm not sure I understand why the "loose" mode change is included with this PR. Could you clarify? I'm a little wary of this as it may impact the generated code in unknown ways.

toddtarsi · 2017-02-10T22:40:28Z

I’m okay with pulling the loose mode change out of this and rebasing it down. Honestly, that's a bit of an artifact, and I just checked, the build succeeds without that change.

…

On Feb 10, 2017, at 4:32 PM, Brian Vaughn ***@***.***> wrote: Hey @toddtarsi <https://github.com/toddtarsi>, Thanks for submitting a patch! That's awesome. For the dependency bump- I wonder if you would also be willing to update the yarn.lock so that it and package.json stay in sync? I'm not sure I understand why the "loose" mode change is included with this PR. Could you clarify? I'm a little wary of this as it may impact the generated code in unknown ways. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#572 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEfUsb0Z1MRaqyGGDHSUVPd9zsfi3aa4ks5rbOWWgaJpZM4L95xr>.

bvaughn · 2017-02-10T22:41:03Z

I'd be much more comfortable with changing only the deps versions :)

toddtarsi · 2017-02-10T22:43:29Z

There! Rebased accordingly. Thanks for the rapid feedback 😄

bvaughn · 2017-02-10T22:44:54Z

No problem. But would you also be willing to update the yarn.lock so that it and package.json stay in sync?

toddtarsi · 2017-02-10T22:57:44Z

Okay, rebased again! Sorry about that, I haven't used yarn before.

toddtarsi · 2017-02-10T22:58:32Z

I just used two commands:

yarn upgrade babel-prefix-es2015@6.22.0
yarn upgrade babel-prefix-es2015-rollup@3.0.0

bvaughn · 2017-02-10T23:05:09Z

No problem. That looks right to me. 😄

bvaughn · 2017-02-14T00:08:37Z

Did a fresh install and confirmed the error you mentioned above. Ran the following upgrade command and confirmed that the error was resolved:

yarn upgrade babel-preset-es2015@6.22.0
yarn upgrade babel-preset-es2015-rollup@3.0.0

Thanks so much for taking the time to put this PR together!

toddtarsi · 2017-02-14T03:58:39Z

Thanks so much for sharing the great repo! 👍

bvaughn · 2017-02-18T19:57:36Z

Thanks again for this fix 😁 I ran into the same problem with react-presents and redux-search and was able to just apply the same technique as you did here without wasting any time on it.

toddtarsi force-pushed the resolve-build-issues branch from 052135f to 150e6b6 Compare February 10, 2017 22:42

(Build fix) babel-preset-es2015 updates

5616e5b

toddtarsi force-pushed the resolve-build-issues branch from 150e6b6 to 5616e5b Compare February 10, 2017 22:55

bvaughn merged commit eedbe2b into bvaughn:master Feb 14, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(Build fix) babel-preset-es2015 updates #572

(Build fix) babel-preset-es2015 updates #572

toddtarsi commented Feb 10, 2017 •

edited

Loading

bvaughn commented Feb 10, 2017

toddtarsi commented Feb 10, 2017 via email

bvaughn commented Feb 10, 2017

toddtarsi commented Feb 10, 2017

bvaughn commented Feb 10, 2017

toddtarsi commented Feb 10, 2017

toddtarsi commented Feb 10, 2017

bvaughn commented Feb 10, 2017

bvaughn commented Feb 14, 2017

toddtarsi commented Feb 14, 2017

bvaughn commented Feb 18, 2017

(Build fix) babel-preset-es2015 updates #572

(Build fix) babel-preset-es2015 updates #572

Conversation

toddtarsi commented Feb 10, 2017 • edited Loading

bvaughn commented Feb 10, 2017

toddtarsi commented Feb 10, 2017 via email

bvaughn commented Feb 10, 2017

toddtarsi commented Feb 10, 2017

bvaughn commented Feb 10, 2017

toddtarsi commented Feb 10, 2017

toddtarsi commented Feb 10, 2017

bvaughn commented Feb 10, 2017

bvaughn commented Feb 14, 2017

toddtarsi commented Feb 14, 2017

bvaughn commented Feb 18, 2017

toddtarsi commented Feb 10, 2017 •

edited

Loading