Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

columnIndex added to table column's cellRenderer function #662

Merged
merged 1 commit into from
Apr 29, 2017

Conversation

bamaboy
Copy link

@bamaboy bamaboy commented Apr 27, 2017

Actually, this thing started, with CellMeasurer ☺️.
Table's demo works fine if we have only one dynamic column.
But if we want to have two or more dynamic columns, something like this happens.

We have to pass columnIndex to cellRenderer, and then to CellMeasurer, to make it work.
Of course we can do it manually, but it would be nice if cellRenderer function had access to columnIndex.

@bvaughn
Copy link
Owner

bvaughn commented Apr 29, 2017

This seems like a reasonable change. Can confirm that Table with multi-columns using CellMeasurer works fine with this. Thanks for submitting the PR!

@bvaughn bvaughn merged commit 379b737 into bvaughn:master Apr 29, 2017
@bvaughn
Copy link
Owner

bvaughn commented Apr 29, 2017

Released as 9.7.4

@bamaboy
Copy link
Author

bamaboy commented Apr 29, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants