Make itemData generic in grids and lists #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this PR I am trying to achieve more sound implementation of itemData props in all grids and lists. To prevent `empty` type itemData is made optional with defaultProps. `flow` script is replaced with `flow:check` to allow running `yarn flow status` to view all errors and warnings.
bvaughn
reviewed
Oct 3, 2018
| @@ -5,5 +5,5 @@ before_script: | |||
| - yarn | |||
| script: | |||
| - yarn lint | |||
| - yarn flow | |||
| - yarn flow:check | |||
There was a problem hiding this comment.
Why?
I prefer yarn flow since it's less to type and what I use in most of my other projects. 😄
There was a problem hiding this comment.
I run yarn flow often. The script with the same name overrides bin.
| @@ -0,0 +1,154 @@ | |||
| // @flow | |||
There was a problem hiding this comment.
I understand why this file exists, but I'm not a fan of the name. It's the only snake_case filename in the project. 😄 I think we should rename it to test.js.flow so it will be still be Flow-checked, but it will be excluded from the NPM package.
There was a problem hiding this comment.
I name it like this to not conflict with jest. But yeah, .flow should solve the problem too.
|
Published in 1.2.1 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I am trying to achieve more sound implementation of itemData
props in all grids and lists.
To prevent
emptytype itemData is made optional with defaultProps.flowscript is replaced withcheckto allow runningyarn flow statusto view all errors and warnings.