Prepend environment variables and config values for subparser support #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ronhanson @bw2 Please take a look at this and see if it works for you. Let me know if you want to rebase and squash these commits. Thanks! |
Contributor
|
Seems good to me. @bw2 should we merge? |
Contributor
Author
|
Any word if this can be merged? |
Owner
|
Sorry for taking so long to get to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have a subparser or subcommand configured, the environment variable and config file support breaks the argparse parsing of the arguments.
['--opt', 'subcommand', '--config-opt']must be like['--opt', '--config-opt', 'subcommand']if--config-optis set at the top level parser, or it throws an error.Switching the order of the env-var and config-file parsed arguments to be prepended fixes this issue. It should not cause any other issues, since positional vars are not able to bet set through environment or config files.