Remove superfluous assignments in clone()

bwRavencl · Oct 11, 2024 · eba03aa · eba03aa
1 parent 8af0822
commit eba03aa
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/src/main/java/de/bwravencl/controllerbuddy/input/Mode.java b/src/main/java/de/bwravencl/controllerbuddy/input/Mode.java
@@ -32,7 +32,7 @@
 
 public final class Mode implements Cloneable {
 
-	private UUID uuid;
+	private final UUID uuid;
 	private String description;
 	private Map<Integer, List<IAction<Float>>> axisToActionsMap = new HashMap<>();
 	private Map<Integer, List<IAction<Byte>>> buttonToActionsMap = new HashMap<>();
@@ -65,8 +65,6 @@ private static <V extends Number> Map<Integer, List<IAction<V>>> cloneActionMap(
 	@Override
 	public Object clone() throws CloneNotSupportedException {
 		final var mode = (Mode) super.clone();
-		mode.uuid = uuid;
-		mode.setDescription(description);
 
 		mode.axisToActionsMap = cloneActionMap(axisToActionsMap);
 		mode.buttonToActionsMap = cloneActionMap(buttonToActionsMap);

diff --git a/src/main/java/de/bwravencl/controllerbuddy/input/Profile.java b/src/main/java/de/bwravencl/controllerbuddy/input/Profile.java
@@ -59,11 +59,6 @@ public final class Profile implements Cloneable {
 	public Object clone() throws CloneNotSupportedException {
 		final var profile = (Profile) super.clone();
 
-		profile.setVersion(version);
-		profile.setShowOverlay(showOverlay);
-		profile.setShowVrOverlay(showVrOverlay);
-		profile.setKeyRepeatInterval(keyRepeatInterval);
-
 		final var clonedButtonToModeActionsMap = new HashMap<Integer, List<ButtonToModeAction>>();
 		for (final var entry : buttonToModeActionsMap.entrySet()) {
 			final var buttonToModeActions = new ArrayList<ButtonToModeAction>();