Complement GuildParams struct to comply with Discord's API
#1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedorLap2006
requested changes
Oct 4, 2022
FedorLap2006
added
feature
|
Thanks for the fix folks! ❤️ (And special thanks to @zekroTJA for that tutorial series on YT all those years ago about making Discord Bots in Java that (sort of) got me into programming :P) |
|
One thing however, I might follow-up this PR with implementation of Nullable fields (which would make most fields a custom pointer type), so I wouldn't recommend using the update right away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the
GuildParamsstruct to be complient with theModify Guildpayload as described in the Discord API docs. Therefore, I've also added the two System Channel FlagsSUPPRESS_GUILD_REMINDER_NOTIFICATIONSandSUPPRESS_JOIN_NOTIFICATION_REPLIESto theSystemChannelFlagconstants.This pull request should fix issue #994.