Add message reaction remove emoji event #1563
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FedorLap2006 please give this a review when you get a chance |
FedorLap2006
requested changes
Oct 21, 2024
| @@ -309,6 +309,11 @@ type MessageReactionRemoveAll struct { | |||
| *MessageReaction | |||
| } | |||
|
|
|||
| // MessageReactionRemoveEmoji is the data for a MessageReactionRemoveEmoji event. | |||
| type MessageReactionRemoveEmoji struct { | |||
| *MessageReaction | |||
There was a problem hiding this comment.
Since we're embedding MessageReaction, I think it would be a good idea to mention in the struct that UserID will not be present.
Like this:
+ // NOTE: will not be present in MessageReactionRemoveEmoji eventAnd add omitempty to it.
|
@FedorLap2006 requesting re-review please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for gateway event MESSAGE_REACTION_REMOVE_EMOJI see