Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restapi: retry on 500/503/504 as well as 502 #1586

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

patrickxia
Copy link

This is a sequel to issue #227.

I run a matterbridge bridge and I'm getting 500s from the Discord API from time to time. We should treat them the same as a 503, instead of just immediately giving up.

Since we're adding entries to the switch statement, also clean up the naked 429 to be consistent.

This is a sequel to issue bwmarrin#227.

I run a matterbridge bridge and I'm getting 500s from the Discord API
from time to time. We should treat 500, 503, 504 the same as a 502,
instead of just immediately giving up.

Since we're adding entries to the switch statement, also clean up the
naked 429 to be consistent.
@patrickxia
Copy link
Author

I looked over my logs and found a 503 as well so I've updated my branch. We might as well cluster 500, 503, 504 all the same because they have similar meanings from the client perspective.

@patrickxia patrickxia changed the title restapi: retry on 500s as well as 502s restapi: retry on 500/503/504 as well as 502 Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant