Added .MessageFormat() to emoji struct #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iopred
reviewed
Jul 31, 2018
structs.go
Outdated
| @@ -281,6 +281,19 @@ type Emoji struct { | |||
| Animated bool `json:"animated"` | |||
| } | |||
|
|
|||
| // ChatName returns a correctly formatted Emoji for use in Message content and embeds | |||
| func (e *Emoji) ChatName() string { | |||
There was a problem hiding this comment.
Honestly, I'd personally even be in favour of .String() or .Format or .MessageFormat.
Maybe the latter is the best?
ikkerens
changed the title
ErikMcClure
pushed a commit
to ErikMcClure/discordgo
that referenced
this pull request
Aug 4, 2020
* Added .ChatName() to emoji struct * Renamed ChatName to MessageFormat * Fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.APIName currently covers all REST url cases, but with the introduction of animated Emoji the chat usage of Emoji has become slightly less obvious as well, despite bots being able to use them.
This new func makes usage of custom emoji (including animated ones) easier.