Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IconURL for GuildPreview and GuildWithCounts #885

Merged
merged 27 commits into from
Mar 31, 2022
Merged

IconURL for GuildPreview and GuildWithCounts #885

merged 27 commits into from
Mar 31, 2022

Conversation

Jleagle
Copy link
Contributor

@Jleagle Jleagle commented Mar 1, 2021

No description provided.

FedorLap2006
FedorLap2006 requested changes Mar 2, 2021
View reviewed changes
Copy link
Collaborator

@FedorLap2006 FedorLap2006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think I just missed that thing when was making the PR. Glad you fixed this problem.

interactions.go Outdated Show resolved Hide resolved
interactions.go Outdated Show resolved Hide resolved
interactions.go Outdated Show resolved Hide resolved
@Jleagle Jleagle changed the title Add User field to Interaction Add missing field / parameter Mar 2, 2021
@Jleagle Jleagle changed the title Add missing field / parameter Add missing Interaction field / Add IconURL utility func Mar 5, 2021
@Jleagle Jleagle changed the title Add missing Interaction field / Add IconURL utility func Add missing Interaction field / IconURL utility func Mar 5, 2021
FedorLap2006
FedorLap2006 requested changes Mar 29, 2022
View reviewed changes
interactions.go Outdated Show resolved Hide resolved
structs.go Outdated Show resolved Hide resolved
restapi.go Outdated Show resolved Hide resolved
structs.go Outdated Show resolved Hide resolved
structs.go Show resolved Hide resolved
structs.go Show resolved Hide resolved
@FedorLap2006
Copy link
Collaborator

Sorry review took a long time.
Also note the conflicts.

@FedorLap2006 FedorLap2006 added the feature Major feature implementation label Mar 29, 2022
Jleagle and others added 5 commits March 29, 2022 19:44
@Jleagle
Add withCounts query option to Guild()
b66089e
@Jleagle
Update comments
81587cc
@Jleagle
Split guild func
892ad22
@Jleagle @FedorLap2006
Update structs.go
87a7eeb 
Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
@Jleagle @FedorLap2006
Update structs.go
c5614ec 
Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
@Jleagle
Copy link
Contributor Author

Jleagle commented Mar 29, 2022

@FedorLap2006 Conflicts sorted

FedorLap2006
FedorLap2006 requested changes Mar 30, 2022
View reviewed changes
Copy link
Collaborator

@FedorLap2006 FedorLap2006 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a couple of small issues, looks good to me. However I'm not really sure why you changed formatting in yaml files.

restapi.go Outdated Show resolved Hide resolved
restapi.go Outdated Show resolved Hide resolved
Jleagle and others added 2 commits March 30, 2022 22:31
@Jleagle @FedorLap2006
Update restapi.go
3cf9474 
Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
@Jleagle
Remove variadic
5ec53cc
@Jleagle
Copy link
Contributor Author

Jleagle commented Mar 31, 2022

My IDE was complaining that the yamls had incorrect indents, i can revert?

@FedorLap2006
Copy link
Collaborator

My IDE was complaining that the yamls had incorrect indents, i can revert?

Feel free to.

@Jleagle
Copy link
Contributor Author

Jleagle commented Mar 31, 2022

Done

FedorLap2006
FedorLap2006 requested changes Mar 31, 2022
View reviewed changes
restapi.go Outdated Show resolved Hide resolved
restapi.go Outdated Show resolved Hide resolved
FedorLap2006
FedorLap2006 reviewed Mar 31, 2022
View reviewed changes
restapi.go Outdated Show resolved Hide resolved
@FedorLap2006
Copy link
Collaborator

Thanks for your contribution!

@FedorLap2006 FedorLap2006 changed the title Add missing Interaction field / IconURL utility func IconURL for GuildPreview and GuildWithCounts Mar 31, 2022
@FedorLap2006 FedorLap2006 merged commit cd724aa into bwmarrin:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedorLap2006 FedorLap2006 FedorLap2006 requested changes

Assignees
No one assigned
Labels
feature Major feature implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jleagle @FedorLap2006 @CarsonHoffman