Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative symlink for installed binary #158

Open
UiP9AV6Y opened this issue Feb 28, 2025 · 0 comments · May be fixed by #159
Open

Relative symlink for installed binary #158

UiP9AV6Y opened this issue Feb 28, 2025 · 0 comments · May be fixed by #159

Comments

@UiP9AV6Y
Copy link

I am running bingo in a CI context, with the current working directory name being unpredictable (e.g. /builds/12345/90345/wd)

Im also pointing GOPATH to a location inside the CI
working directory for the purpose of caching. as a
result GOBIN also points to a path inside the working
directory.

I am setting up the build workspace using
bingo get -l and sharing the cached data between
CI jobs.

bingo creates the symlinks with absolute paths,
which makes them unusable in CI jobs other than the
one which ran bingo get -l, as the links point to
nonexistend locations
(e.g. /builds/12345/90345/wd/.cache/golang/bin something when the job working directory is /builds/12345/91112/wd)

As far as i am aware, relative symlinks are supported
on all OS bingo supports.

Is there any objection to creating the symbolic links
relative to the actual binary?
(e.g. instead of /go/bin/something -> /go/bin/something-1.2.3, create /go/bin/something -> something-1.2.3)

UiP9AV6Y added a commit to UiP9AV6Y/bingo that referenced this issue Feb 28, 2025
since the installed binary as well as the symlink reside in the
same directory, relative paths should be safe to use without
having to worry about crossing filesystem boundaries.

closes bwplotka#158
@UiP9AV6Y UiP9AV6Y linked a pull request Feb 28, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant